Log improvements #75
Merged
Log improvements #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jamalam360
commented
Jul 22, 2023
Jamalam360
commented
- Detects using FLK and Fabric API on Quilt.
- Asks for crash reports, and general fixes relating to crash reports. Some regexes were updated and work as they did previously, but with support for crash reports (they were not parsing before for some reason)
This allows parsing crash report mod tables, it wasn't working before. The change doesn't break anything
This allows parsing crash report mod tables, it wasn't working before. The change doesn't break anything
Pyrofab
reviewed
Jul 24, 2023
| @@ -13,7 +13,7 @@ import org.quiltmc.community.cozy.modules.logs.data.Order | |||
| import org.quiltmc.community.cozy.modules.logs.types.LogParser | |||
|
|
|||
| private val PATTERNS = mapOf( | |||
| "\n\\|[\\s\\d]+\\| Quilt Loader\\s+\\| quilt_loader\\s+\\| (\\S+).+\n" | |||
| "\\| Quilt Loader\\s+\\| quilt_loader\\s+\\| (\\S+).+" | |||
There was a problem hiding this comment.
Couldn't this be replaced with a kotlin raw string to reduce the amount of escaping ?
There was a problem hiding this comment.
Probably. I don't think any other regexes use that but it would be an improvement to change them all
There was a problem hiding this comment.
but if any of them use $ we have to use this ugliness """${'$'}"""
There was a problem hiding this comment.
just wait until you hear about kotlin backtick escaping allowing $`$` by referencing a variable instead of the long escape
There was a problem hiding this comment.
Is this a blocking issue for this PR?
sschr15
reviewed
Jul 24, 2023
...r/src/main/kotlin/org/quiltmc/community/cozy/modules/logs/processors/CrashReportProcessor.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.