-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log improvements #75
Log improvements #75
Conversation
Jamalam360
commented
Jul 22, 2023
- Detects using FLK and Fabric API on Quilt.
- Asks for crash reports, and general fixes relating to crash reports. Some regexes were updated and work as they did previously, but with support for crash reports (they were not parsing before for some reason)
This allows parsing crash report mod tables, it wasn't working before. The change doesn't break anything
This allows parsing crash report mod tables, it wasn't working before. The change doesn't break anything
@@ -13,7 +13,7 @@ import org.quiltmc.community.cozy.modules.logs.data.Order | |||
import org.quiltmc.community.cozy.modules.logs.types.LogParser | |||
|
|||
private val PATTERNS = mapOf( | |||
"\n\\|[\\s\\d]+\\| Quilt Loader\\s+\\| quilt_loader\\s+\\| (\\S+).+\n" | |||
"\\| Quilt Loader\\s+\\| quilt_loader\\s+\\| (\\S+).+" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't this be replaced with a kotlin raw string to reduce the amount of escaping ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably. I don't think any other regexes use that but it would be an improvement to change them all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but if any of them use $
we have to use this ugliness """${'$'}"""
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just wait until you hear about kotlin backtick escaping allowing $`$`
by referencing a variable instead of the long escape
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a blocking issue for this PR?